[Webkit-unassigned] [Bug 89898] Fast path for simple transform parsing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 25 12:14:41 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89898





--- Comment #4 from Oliver Hunt <oliver at apple.com>  2012-06-25 12:14:41 PST ---
(From update of attachment 149337)
View in context: https://bugs.webkit.org/attachment.cgi?id=149337&action=review

>> Source/WebCore/css/CSSParser.cpp:1033
>> +    if (string.length() < 13 || string.length() > 32)
> 
> I'd be nice if you explained the less than check as well.

I don't like the magic numbers here.  This almost feels like something we want to auto generate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list