[Webkit-unassigned] [Bug 89898] Fast path for simple transform parsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89898


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #149337|review?                     |review+
               Flag|                            |




--- Comment #3 from Anders Carlsson <andersca at apple.com>  2012-06-25 12:01:28 PST ---
(From update of attachment 149337)
View in context: https://bugs.webkit.org/attachment.cgi?id=149337&action=review

> Source/WebCore/css/CSSParser.cpp:1009
> +static bool parseTransformArguments(PassRefPtr<WebKitCSSTransformValue> transformValue, CharType* characters, unsigned length, unsigned start, unsigned expectedCount)
> +{

I don't think this needs to take a PassRefPtr, just a raw pointer would be fine.

> Source/WebCore/css/CSSParser.cpp:1033
> +    // Very long strings probably have multiple components which we don't handle here.
> +    if (string.length() < 13 || string.length() > 32)

I'd be nice if you explained the less than check as well.

> Source/WebCore/css/CSSParser.cpp:1038
> +    UChar c9 = toASCIILowerUnchecked(string[9]);
> +    UChar c10 = toASCIILowerUnchecked(string[10]);

Is it OK to use unchecked here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.