[Webkit-unassigned] [Bug 73544] [EFL] Support for Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544


Kihong Kwon <kihong.kwon at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148060|0                           |1
        is obsolete|                            |
 Attachment #148240|                            |review?
               Flag|                            |




--- Comment #61 from Kihong Kwon <kihong.kwon at samsung.com>  2012-06-18 21:37:55 PST ---
Created an attachment (id=148240)
 --> (https://bugs.webkit.org/attachment.cgi?id=148240&action=review)
Patch

> > > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:-24
> > > -#include "NotImplemented.h"
> > 
> > When NOTIFICATION is disabled, there is build break as below,
> > 
> > 86%] Building CXX object Source/WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/PageClientEfl.cpp.o
> > In file included from /home/gyuyoung/webkit/WebKit/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:21:0:
> > /home/gyuyoung/webkit/WebKit/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:24:26: fatal error: Notification.h: No such file or directory
> > 
> LEGACY_NOTIFICATION is like a optional feature of NOTIFICATION, therefore there is no chance to enable LEGACY_NOTIFICATION without NOTIFICAION.
> (there are some link errors from WebCore by WebCore/CMakeLIsts.txt:1703)
> But I will change this.

If I fix this, we need to change position of "${WEBCORE_DIR}/notifications" in the platformEfl.txt

>From : 
IF (ENABLE_NOTIFICATIONS)
  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
    "${WEBCORE_DIR}/notifications"
  )
ENDIF ()

To :
  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
    ...
    "${WEBCORE_DIR}/notifications"
    ...
  )

But, there are remaining errors in the WebCore as I said above.
Therefore, I don't want to change this now.
When ENABLE_NOTIFICATION feature is deleted for enabling by default, we can change this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.