[Webkit-unassigned] [Bug 73544] [EFL] Support for Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #60 from Kihong Kwon <kihong.kwon at samsung.com>  2012-06-18 18:10:30 PST ---
(In reply to comment #59)
> (From update of attachment 148060 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148060&action=review
> 
> Could you let me know what is difference between NOTIFICATION feature and LEGACY_NOTIFICATIONS? It is a little difficult to understand the difference in this patch.

NOTIFICATION support to the Web Notification of w3c otherwise, LEGACY_NOTIFICATION support to the old version of the Web Notification.
NOTIFICATION(http://dvcs.w3.org/hg/notifications/raw-file/tip/Overview.html)
LEGACY_NOTIFICATION(http://www.chromium.org/developers/design-documents/desktop-notifications/api-specification)
> 
> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:-24
> > -#include "NotImplemented.h"
> 
> When NOTIFICATION is disabled, there is build break as below,
> 
> 86%] Building CXX object Source/WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/PageClientEfl.cpp.o
> In file included from /home/gyuyoung/webkit/WebKit/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:21:0:
> /home/gyuyoung/webkit/WebKit/Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.h:24:26: fatal error: Notification.h: No such file or directory
> 
LEGACY_NOTIFICATION is like a optional feature of NOTIFICATION, therefore there is no chance to enable LEGACY_NOTIFICATION without NOTIFICAION.
(there are some link errors from WebCore by WebCore/CMakeLIsts.txt:1703)
But I will change this.

> > Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:77
> > +    // Called from ~Notification(), Remove the entry from the notifications list.
> 
> s/Remove/remove/g

OK.
> 
> > Source/WebKit/efl/ewk/ewk_notification.cpp:131
> > +    return strdup(ewkNotification->notification->replaceId().utf8().data());
> 
> When LEGACY_NOTIFICATION is disabled, there is a build break. We have to support perfect build regardless of feature dependency.
> 
> /home/gyuyoung/webkit/WebKit/Source/WebKit/efl/ewk/ewk_notification.cpp: In function ‘const char* ewk_notification_replace_id_get(const Ewk_Notification*)’:
> /home/gyuyoung/webkit/WebKit/Source/WebKit/efl/ewk/ewk_notification.cpp:131:50: error: ‘class WebCore::Notification’ has no member named ‘replaceId’
> [ 99%] Built target ewebkit2

OK, You are right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.