[Webkit-unassigned] [Bug 88326] [BlackBerry] [DRT] DRT should be able to run interactively and support multiple processes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88326





--- Comment #6 from Xiaobo Wang <xiaobo.wang at torchmobile.com.cn>  2012-06-15 01:03:16 PST ---
(In reply to comment #3)
> (From update of attachment 145995 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145995&action=review
> 
> Looks good, can maybe be cleaned up some more, also judging from Ming's comment.
> 
> > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:344
> > +                S_IROTH | S_IWOTH);
> 
> I think alignment could be a bit better here, more can be put onto one line.
> 
> > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:354
> > +    const int lenTestFile = 11;
> 
> Better to not hardcode this I think.

Good suggestions, updated in the new patch. Thanks Rob.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.