[Webkit-unassigned] [Bug 87283] [GTK] run-file-chooser signal for WebKit1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87283





--- Comment #26 from Mario Sanchez Prada <msanchez at igalia.com>  2012-06-15 00:34:24 PST ---
(In reply to comment #25)
> [...]
> > I miss a comment about the lifecycle of the FileChooserRequest object and how 
> > to handle this async. If I want to handle this signal asynchronously, do I 
> > ref the request, return TRUE and then call its select_files() method when I 
> > have the chosen files? If that's the case (and it seems to be from my quick 
> > inspection of the default handler), then I think the API looks good, but 
> > having this spelled out here would help =).
> 
> This was just a copy/paste from the WebKit2 gobject API. Mario, can you help
> me answer this? Is Gustavo's interpretation correct?

I think Gustavo means adding an extra comment to the run-file-chooser signal, in a similar fashion to what it's done for geolocation-policy-decision-requested:

    /**
     * WebKitWebView::geolocation-policy-decision-requested:
     * @web_view: the object on which the signal is emitted
     * @frame: the frame that requests permission
     * @policy_decision: a WebKitGeolocationPolicyDecision
     *
     * This signal is emitted when a @frame wants to obtain the user's
     * location. The decision can be made asynchronously, but you must
     * call g_object_ref() the @policy_decision, and return %TRUE if
     * you are going to handle the request. To actually make the
     * decision you need to call webkit_geolocation_policy_allow() or
     * webkit_geolocation_policy_deny() on @policy_decision.
     *
     * Since: 1.1.23
     */

Is this my interpretation correct, Gustavo?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.