[Webkit-unassigned] [Bug 84936] [chromium] Compute highlight for touch targets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84936





--- Comment #48 from Tien-Ren Chen <trchen at chromium.org>  2012-06-14 15:15:45 PST ---
(In reply to comment #47)
> (In reply to comment #46)
> > (In reply to comment #44)
> > > > > is not it what Source/WebCore/page/GestureTapHighlighter.cpp is responsible for, among others? (see also https://bugs.webkit.org/show_bug.cgi?id=84989)
> > > > 
> > > > GestureTapHighlighter has some major flaws that I don't think are easily fixable.
> > > > 1. The support for transformation is terribly wrong. It gets the absoluteRects then apply layer transformation again?
> > > > 2. It doesn't separate highlights for different graphicsLayer. Which is essential to support threaded-scrolling/CSS animation.
> > > 
> > > Zalan would be interested in improving this, I think.
> > 
> > Why not just use our version? ;)
> > 
> > I tried the GestureTapHighlighter based version with various test cases (see "some additional test cases" in the attachments), most of them result in a unusable highlight.
> > 
> > Besides transformation, it also generates wrong box for inline elements for some cases.
> Agree, GestureTapHighlighter has multiple known issues, which were planned to be improved gradually. Since it doesn't make much sense to maintain 2 different implementations of the same feature, I'll check if we can have qt to use this.

Sorry for the delay in reply. I'm currently on a 2-weeks vacation. Will try to reply within 48 hours.

I think our RenderObject::hitQuadsForContainer works very similar to RenderObject::addFocusRingRects if you pass null as the repaintContainer (so it returns in absolute coordinate), except with two difference:

1. hitQuadsForContainer returns quads instead of rects. If the rendering code is not capable of dealing with quads, I think using the enclosingBoundingBox would be a feasible solution.

2. hitQuadsForContainer returns the raw hit-rects without decorations such as rounded-corner. Our "beautifying" code in is done in the WebHighlight class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.