[Webkit-unassigned] [Bug 84936] [chromium] Compute highlight for touch targets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84936





--- Comment #47 from Zalan Bujtas <zbujtas at gmail.com>  2012-06-11 05:52:16 PST ---
(In reply to comment #46)
> (In reply to comment #44)
> > > > is not it what Source/WebCore/page/GestureTapHighlighter.cpp is responsible for, among others? (see also https://bugs.webkit.org/show_bug.cgi?id=84989)
> > > 
> > > GestureTapHighlighter has some major flaws that I don't think are easily fixable.
> > > 1. The support for transformation is terribly wrong. It gets the absoluteRects then apply layer transformation again?
> > > 2. It doesn't separate highlights for different graphicsLayer. Which is essential to support threaded-scrolling/CSS animation.
> > 
> > Zalan would be interested in improving this, I think.
> 
> Why not just use our version? ;)
> 
> I tried the GestureTapHighlighter based version with various test cases (see "some additional test cases" in the attachments), most of them result in a unusable highlight.
> 
> Besides transformation, it also generates wrong box for inline elements for some cases.
Agree, GestureTapHighlighter has multiple known issues, which were planned to be improved gradually. Since it doesn't make much sense to maintain 2 different implementations of the same feature, I'll check if we can have qt to use this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.