[Webkit-unassigned] [Bug 88326] [BlackBerry] [DRT] DRT should be able to run interactively and support multiple processes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 11:55:54 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88326


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145995|review?                     |review-
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2012-06-13 11:55:53 PST ---
(From update of attachment 145995)
View in context: https://bugs.webkit.org/attachment.cgi?id=145995&action=review

Looks good, can maybe be cleaned up some more, also judging from Ming's comment.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:344
> +                S_IROTH | S_IWOTH);

I think alignment could be a bit better here, more can be put onto one line.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:354
> +    const int lenTestFile = 11;

Better to not hardcode this I think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list