[Webkit-unassigned] [Bug 88326] [BlackBerry] [DRT] DRT should be able to run interactively and support multiple processes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88326





--- Comment #2 from Ming Xie <mxie at rim.com>  2012-06-13 08:25:46 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=145995&action=review

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:170
> +    m_doneFile = sdcardPath + "/done" + workerNumber;

Wouldn't use pid be better? We don't need to check this env var if we use getpid()

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:242
> +//        doneDrt();

code clean up?

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:328
> +void DumpRenderTree::ensurePPS()

Can we make this as a bool function, so we can handle differently if PPS isn't ready?

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:336
> +        currentPath += ("/" + nodes[i]);

Sorry, I'm a bit confused. what's the difference between the ppsPathString and currentPath here?

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:376
> +                m_refTests.append(testFile);

isn't refTests being removed from here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.