[Webkit-unassigned] [Bug 88950] [Blackberry] add a new Api named setAllowNotification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88950





--- Comment #7 from Chris.Guan <chris.guan at torchmobile.com.cn>  2012-06-13 08:08:31 PST ---
(In reply to comment #3)
> (From update of attachment 147257 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=147257&action=review
> 
> It looks good. I wonder if it fits better to WebSettings instead of WebPage. What you you think?
> 
> > Source/WebKit/blackberry/Api/WebPage.cpp:6346
> > +void WebPage::setAllowNotification(const WebString& domain, bool allow)
> 
> I think you need UNUSED_PARAM for 'domain' and 'allow' in an #else block


yes, UNUSED_PARAM is good, :)  I am thinking refactor notification, because upstream code has changed a lot since we started implementing notification, I feel notificationClient is a better candidate class by which QT port is using.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.