[Webkit-unassigned] [Bug 88950] [Blackberry] add a new Api named setAllowNotification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 08:00:59 PDT 2012


--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-06-13 08:00:58 PST ---
(From update of attachment 147257)
View in context: https://bugs.webkit.org/attachment.cgi?id=147257&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:6349
> +    static_cast<NotificationPresenterImpl*>(NotificationPresenterImpl::instance())->onPermission(domain.utf8(), allow);

Since this is a singleton, is it a problem that a new page will "inherit" this?

> Source/WebKit/blackberry/Api/WebPage.h:269
> +    void setAllowNotification(const WebString& domain, bool allow);

Would it make sense for the whole method to be wrapped in #if ENABLE(NOTIFICATIONS) ?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list