[Webkit-unassigned] [Bug 80597] [WK2] Add WKHitTestResultIsContentEditable()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80597





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-06-13 05:32:19 PST ---
(In reply to comment #8)
> (From update of attachment 130824 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=130824&action=review
> 
> Normally I would not review patches that affect the C WebKit API, but this patch has been sitting for a very long time with no input. The API makes a lot of sense to me, but given that the WebKit2 team hasn't really chimed in, I think it's better to make this API private when landing. You can just move the new API to Source/WebKit2/UIProcess/API/C/WKHitTestResultPrivate.h.

That would require adding a new file, so I would have the same problem that in bug #79482, I don't have a mac, and I have no idea how to deal with xcode files :-(

> > Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:360
> > + * Returns: %TRUE if there's an editable element in the coordinates of the Hit Test,
> 
> Maybe @hit_test_result would be better than " the Hit Test"

Ok

> Should probably say "at the coordinates" instead of "in the coordinates"

Sure.

Thanks for reviewing!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.