[Webkit-unassigned] [Bug 80597] [WK2] Add WKHitTestResultIsContentEditable()

Fri Jun 8 16:08:54 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=80597

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #130824|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2012-06-08 16:08:54 PST ---
(From update of attachment 130824)
View in context: https://bugs.webkit.org/attachment.cgi?id=130824&action=review

Normally I would not review patches that affect the C WebKit API, but this patch has been sitting for a very long time with no input. The API makes a lot of sense to me, but given that the WebKit2 team hasn't really chimed in, I think it's better to make this API private when landing. You can just move the new API to Source/WebKit2/UIProcess/API/C/WKHitTestResultPrivate.h.

> Source/WebKit2/UIProcess/API/gtk/WebKitHitTestResult.cpp:360
> + * Returns: %TRUE if there's an editable element in the coordinates of the Hit Test,

Maybe @hit_test_result would be better than " the Hit Test"

Should probably say "at the coordinates" instead of "in the coordinates"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.