[Webkit-unassigned] [Bug 80702] [Qt][WK2] Implement web notifications support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80702





--- Comment #10 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-06-13 00:46:19 PST ---
(From update of attachment 147135)
View in context: https://bugs.webkit.org/attachment.cgi?id=147135&action=review

> Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp:33
> +        , geoRequest(geo)
> +        , notifyRequest(notify)

geolocationRequest
notificationRequest

> Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp:72
> +QWebPermissionRequest::QWebPermissionRequest(WKSecurityOriginRef securityOrigin
> +                                             , WKGeolocationPermissionRequestRef geo
> +                                             , WKNotificationPermissionRequestRef notify
> +                                             , QWebPermissionRequest::RequestType type
> +                                             , QObject* parent)

wrong indentation, this should just be one line

Wouldn't two different ctors make sense?

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml:20
> +        //Must be false by default

space

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml:24
> +        if (!permission.allow) {
> +           permission.allow = true
> +        } else
> +           console.log("Fail: permission must be set to false")

inconsistent coding style

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.