[Webkit-unassigned] [Bug 73544] [EFL] Support for Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145722|review?                     |review-
               Flag|                            |




--- Comment #53 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-10 04:47:32 PST ---
(From update of attachment 145722)
View in context: https://bugs.webkit.org/attachment.cgi?id=145722&action=review

> Source/WebKit/efl/ChangeLog:9
> +        In this patch, we support following apis and events.

s/apis/APIs/g

> Source/WebKit/efl/ewk/ewk_notification.cpp:91
> +Eina_Stringshare* ewk_notification_title_get(Ewk_Notification* ewkNotification)

Add const keyword for _get().

> Source/WebKit/efl/ewk/ewk_notification.cpp:100
> +Eina_Stringshare* ewk_notification_icon_url_get(Ewk_Notification* ewkNotification)

ditto.

> Source/WebKit/efl/ewk/ewk_notification.cpp:109
> +Eina_Stringshare* ewk_notification_body_get(Ewk_Notification* ewkNotification)

ditto.

> Source/WebKit/efl/ewk/ewk_notification.cpp:118
> +Eina_Stringshare* ewk_notification_replace_id_get(Ewk_Notification* ewkNotification)

ditto.

> Source/WebKit/efl/ewk/ewk_notification.cpp:127
> +Eina_Stringshare* ewk_notification_dir_get(Ewk_Notification* ewkNotification)

ditto.

> Source/WebKit/efl/ewk/ewk_notification.h:23
> + */

Please write more detail description.

> Source/WebKit/efl/ewk/ewk_notification.h:88
> +EAPI Eina_Stringshare *ewk_notification_icon_url_get(Ewk_Notification *en);

By the way,  why we have to return string by Eina_Stringshare ? As you know, application have to delete returned string by eina function. EFL port has used const char* for similar case.

> Source/WebKit/efl/ewk/ewk_notification_private.h:32
> +#endif // ewk_settings_private_h

s/ewk_settings_private_h/ewk_notification_private.h/g

> Source/WebKit/efl/ewk/ewk_view.cpp:4391
> +const WebCore::NotificationPresenterClientEfl* ewk_view_notification_client_get(Evas_Object* ewkView)

Missing const keyword.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.