[Webkit-unassigned] [Bug 73544] [EFL] Support for Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #54 from Kihong Kwon <kihong.kwon at samsung.com>  2012-06-11 01:14:45 PST ---
(From update of attachment 145722)
View in context: https://bugs.webkit.org/attachment.cgi?id=145722&action=review

>> Source/WebKit/efl/ChangeLog:9
>> +        In this patch, we support following apis and events.
> 
> s/apis/APIs/g

OK.

>> Source/WebKit/efl/ewk/ewk_notification.cpp:91
>> +Eina_Stringshare* ewk_notification_title_get(Ewk_Notification* ewkNotification)
> 
> Add const keyword for _get().

OK.

>> Source/WebKit/efl/ewk/ewk_notification.h:23
>> + */
> 
> Please write more detail description.

OK.

>> Source/WebKit/efl/ewk/ewk_notification.h:88
>> +EAPI Eina_Stringshare *ewk_notification_icon_url_get(Ewk_Notification *en);
> 
> By the way,  why we have to return string by Eina_Stringshare ? As you know, application have to delete returned string by eina function. EFL port has used const char* for similar case.

OK. I don't care about that. I will change Eina_Stringshare to cont cnar*.

>> Source/WebKit/efl/ewk/ewk_notification_private.h:32
>> +#endif // ewk_settings_private_h
> 
> s/ewk_settings_private_h/ewk_notification_private.h/g

OK.

>> Source/WebKit/efl/ewk/ewk_view.cpp:4391
>> +const WebCore::NotificationPresenterClientEfl* ewk_view_notification_client_get(Evas_Object* ewkView)
> 
> Missing const keyword.

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.