[Webkit-unassigned] [Bug 88087] [SOUP] WebSoupRequestManager should handle loading errors and zero-length replies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88087





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-06-06 23:12:30 PST ---
(In reply to comment #2)
> (From update of attachment 145292 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145292&action=review
> 
> > Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:50
> > +        // If the struct contains a null request is because the request failed.
> 
> Nit: request is -> request, it is

Ok.

> > Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:65
> > +    GSimpleAsyncResult* releaseResult()
> 
> It would make sense for this to return a GRefPtr to avoid a leak.

The only user of that method already adopts the ref, so it's not leaked.

> > Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:147
> > +    if (!data)
> > +        return;
> 
> Above you ASSERT data and here you return. Is there a situation where you expect data to be null here?

Yes, it's unlikely but possible. If there are more than one chunk messages sent by the UI process and the first one fails. The data is removed from the map, and a message is sent to the UI process to stop sending more chunk messages. The next chunk message already sent will be silently ignored if there's no data for for it in the request map.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.