[Webkit-unassigned] [Bug 88087] [SOUP] WebSoupRequestManager should handle loading errors and zero-length replies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88087


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145292|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-06-06 09:48:26 PST ---
(From update of attachment 145292)
View in context: https://bugs.webkit.org/attachment.cgi?id=145292&action=review

> Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:50
> +        // If the struct contains a null request is because the request failed.

Nit: request is -> request, it is

> Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:65
> +    GSimpleAsyncResult* releaseResult()

It would make sense for this to return a GRefPtr to avoid a leak.

> Source/WebKit2/WebProcess/soup/WebSoupRequestManager.cpp:147
> +    if (!data)
> +        return;

Above you ASSERT data and here you return. Is there a situation where you expect data to be null here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.