[Webkit-unassigned] [Bug 79861] DragData::asFilenames push same file to result in windows platform

Wed Jun 6 06:54:22 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=79861


--- Comment #17 from huangxueqing <huangxueqing at baidu.com>  2012-06-06 06:54:19 PST ---
(In reply to comment #16)
> (From update of attachment 145477 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145477&action=review
> 
> > LayoutTests/platform/win/fast/events/drag-and-drop-files.html:1
> > +<body>
> 
> Instead of using custom output for the expected file, please use the js-test-{pre,post}.js pattern (see any of the tests in fast/forms/file/ as an example).
> 
Done

> Because this test does not test the drag event, this should really be in fast/forms/file. And is there any reason why this has to be windows-specific, instead of all platforms?
OK, i will move it to fast/forms/file.
This bug was only reproduce in webkit1 Windows port, I don't know whether this test does make sense to other ports.

> 
> > LayoutTests/platform/win/fast/events/drag-and-drop-files.html:6
> > +    layoutTestController.dumpAsText()
> 
> Nit: missing semicolon
As you said, i will use js-test-{pre,post}.js rather than custom expected file. BTW, this js was a wonderful tool to write test case.

> 
> > LayoutTests/platform/win/fast/events/drag-and-drop-files.html:16
> > +    var targetY = 10;
> 
> Why are targetX and targetY being defined twice?
Typo

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.