[Webkit-unassigned] [Bug 79861] DragData::asFilenames push same file to result in windows platform

Tue Jun 5 12:28:56 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=79861

--- Comment #16 from Jon Lee <jonlee at apple.com>  2012-06-05 12:28:55 PST ---
(From update of attachment 145477)
View in context: https://bugs.webkit.org/attachment.cgi?id=145477&action=review

> LayoutTests/platform/win/fast/events/drag-and-drop-files.html:1
> +<body>

Instead of using custom output for the expected file, please use the js-test-{pre,post}.js pattern (see any of the tests in fast/forms/file/ as an example).

Because this test does not test the drag event, this should really be in fast/forms/file. And is there any reason why this has to be windows-specific, instead of all platforms?

> LayoutTests/platform/win/fast/events/drag-and-drop-files.html:6
> +    layoutTestController.dumpAsText()

Nit: missing semicolon

> LayoutTests/platform/win/fast/events/drag-and-drop-files.html:16
> +    var targetY = 10;

Why are targetX and targetY being defined twice?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.