[Webkit-unassigned] [Bug 72099] [WK2] Keyboard menu key should show context menu

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 00:40:04 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=72099





--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-06-01 00:40:04 PST ---
(In reply to comment #17)
> (In reply to comment #14)
> > (From update of attachment 145216 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=145216&action=review
> > 
> > > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:467
> > > +#if ENABLE(CONTEXT_MENUS)
> > > +    WEBKIT_WEB_VIEW_BASE(widget)->priv->pageProxy->handleContextMenuKeyEvent();
> > > +    return TRUE;
> > > +#endif // ENABLE(CONTEXT_MENUS)
> > 
> > Isn't context menu always enabled when building gtk port?
> Yes, Enabled always. Gtk-port might give errors when Context menu is disabled.
> 

So we don't need the #if then, no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list