[Webkit-unassigned] [Bug 72099] [WK2] Keyboard menu key should show context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72099





--- Comment #17 from chandra shekar vallala <chandra.vallala at motorola.com>  2012-06-01 00:28:29 PST ---
(In reply to comment #14)
> (From update of attachment 145216 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145216&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:467
> > +#if ENABLE(CONTEXT_MENUS)
> > +    WEBKIT_WEB_VIEW_BASE(widget)->priv->pageProxy->handleContextMenuKeyEvent();
> > +    return TRUE;
> > +#endif // ENABLE(CONTEXT_MENUS)
> 
> Isn't context menu always enabled when building gtk port?
Yes, Enabled always. Gtk-port might give errors when Context menu is disabled.

> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:619
> > +    widgetClass->popup_menu = webkitWebViewPopupMenuHandler;
> 
> We use the pattern classNameSignalName, so this should be webkitWebViewBasePopupMenu()
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.