[Webkit-unassigned] [Bug 92089] Web Inspector: Protocol Extension: Refactor protocol extension for CSS Regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92089





--- Comment #6 from Andrei Poenaru <poenaru at adobe.com>  2012-07-31 04:29:16 PST ---
(In reply to comment #5)
> (From update of attachment 154641 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154641&action=review
> 
> >>> Source/WebCore/inspector/Inspector.json:2336
> >>> +                    { "name": "namedFlows", "type": "array", "items": { "$ref": "NamedFlow" }, "description": "An array containing the Named Flows in the document." }
> >> 
> >> You should remove getFlowByName now, right?
> > 
> > The reason why I proposed this method is to avoid the overhead of requesting all named flows when one changes, or a new flow is created.
> 
> What is the origin of the named flow changes? Is it CSSOM? If so, can you push the update into the frontend using an event instead?

I will also add some events, but, in order to keep them lightweight, they are sending only the name of the flow.

> > Source/WebCore/inspector/InspectorDOMAgent.h:169
> > +    int pushNodePathToFrontend(Node*);
> 
> What is the rationale behind this change? The two push* methods seem to have been properly grouped originally.

The reason why I made this method public is to be able to get the NodeIds for the content nodes and for the regions (they may not have been sent yet to the frontend).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.