[Webkit-unassigned] [Bug 92089] Web Inspector: Protocol Extension: Refactor protocol extension for CSS Regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92089





--- Comment #5 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-07-31 04:09:08 PST ---
(From update of attachment 154641)
View in context: https://bugs.webkit.org/attachment.cgi?id=154641&action=review

>>> Source/WebCore/inspector/Inspector.json:2336
>>> +                    { "name": "namedFlows", "type": "array", "items": { "$ref": "NamedFlow" }, "description": "An array containing the Named Flows in the document." }
>> 
>> You should remove getFlowByName now, right?
> 
> The reason why I proposed this method is to avoid the overhead of requesting all named flows when one changes, or a new flow is created.

What is the origin of the named flow changes? Is it CSSOM? If so, can you push the update into the frontend using an event instead?

> Source/WebCore/inspector/InspectorCSSAgent.cpp:837
> +    RefPtr<WebKitNamedFlow> refWebKitNamedFlow(webKitNamedFlow);

This line is not necessary. You could try passing webKitNamedFlow directly into buildObjectForNamedFlow(PassRefPtr<WebKitNamedFlow>...) and see if the respective PassRefPtr will get constructed automatically.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:1086
> +                continue;

Should this ASSERT_NOT_REACHED() as well?

> Source/WebCore/inspector/InspectorDOMAgent.h:169
> +    int pushNodePathToFrontend(Node*);

What is the rationale behind this change? The two push* methods seem to have been properly grouped originally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.