[Webkit-unassigned] [Bug 91482] [GTK] No main resource in WebView on load committed when page has been loaded from history cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91482





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-07-31 03:10:22 PST ---
(From update of attachment 152725)
View in context: https://bugs.webkit.org/attachment.cgi?id=152725&action=review

>>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1155
>>> +        setCertificateToMainResourceOrWait(webView);
>> 
>> I think it might be good to move
>> 
>> priv->waitingForMainResource = true;
>> 
>> to here and get rid of setCertificateToMainResourceOrWait. Right now it feels like it's a side-effect of setCertificateToMainResourceOrWait, while it affects more than just certificate handling (also emitting delayed loading events), so it's somewhat "hidden" away.
>> 
>> Also above that line I believe a comment explaining why we sometimes wait for the resource to load -- explaining the situation of back and forward with cached resources.
> 
> So, are you proposing to move the contents of the helper function here?

Sure, I think it would be sufficient just to move the contents of setCertificateToMainResourceOrWait here and to keep setCertificateToMainResource. It's mostly just the name, in fact, setCertificateToMainResourceOrWait is also important in situations when there is no certificate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.