[Webkit-unassigned] [Bug 74680] [Plugins GTK/QT] Signed to Unsigned Conversion Error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74680


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at samsung.com




--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-17 03:17:14 PST ---
(In reply to comment #6)
> Created an attachment (id=135250)
 --> (https://bugs.webkit.org/attachment.cgi?id=135250&action=review) [details]
> Signed to Unsigned Conversion Error
> 
> rebase the patch.
> 
> When tested webkit for desktop, it's not need this patch.
> My testing environment is using floating viewport for mobile browser( view is bigger than device screen).
> For getting m_windowRect, I'm using contentsToScreen instead of contentsToWindow.
> so, m_windowRect.x or y can be the negative.
> 
> However, I think these codes are a basic problem about conversion. ( unsigned = signed )
> this patch will prevent "Signed to Unsigned Conversion Error" and remove the warning in build time.
> 
> How do you think about my opinion ?

As Eric said on comment #4, I think reviewers can accept this patch when you submit this patch with test cases. And, if you have test cases for this patch, I also think this patch can be adjusted to root file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.