[Webkit-unassigned] [Bug 91632] Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91632





--- Comment #6 from Sergey Rogulenko <rogulenko at google.com>  2012-07-31 01:00:09 PST ---
(From update of attachment 155302)
View in context: https://bugs.webkit.org/attachment.cgi?id=155302&action=review

>> Source/WebCore/inspector/DOMNodeHighlighter.cpp:497
>> +    if (m_needsUpdateBeforePainting)
> 
> Why did this appear? What issue does it solve?

When we scroll the page we do not repaint the whole view. So, if we do not do full repaint, there may appear multiple elementTitles on the screen. So I added this to force repainting of the whole overlay.

>> Source/WebCore/inspector/DOMNodeHighlighter.cpp:593
>> +    IntRect visibleRect = IntRect(IntPoint(), frame->view()->visibleContentRect().size());
> 
> What was wrong with the old visibleContentRect()?
> You can use frame->view()->visibleSize() for brevity.

The problem here could appear when you open a page, scroll down and press pause button. The position of visibleContentRect is (0, y), where y > 0, but the context is configured so that the upper-left corner is (0, 0). So the drawing rect would be painted below its proper place. Maybe it is better to do context.translate?

>> Source/WebCore/inspector/InspectorDOMAgent.cpp:1017
>> +        return PassOwnPtr<HighlightConfig> ();
> 
> Will "return 0;" work in this case, like it does for PassRefPtr's?

I tried return 0, but it didn't compile.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.