[Webkit-unassigned] [Bug 91632] Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91632





--- Comment #5 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-07-30 12:43:29 PST ---
(From update of attachment 155302)
View in context: https://bugs.webkit.org/attachment.cgi?id=155302&action=review

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:497
> +    if (m_needsUpdateBeforePainting)

Why did this appear? What issue does it solve?

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:593
> +    IntRect visibleRect = IntRect(IntPoint(), frame->view()->visibleContentRect().size());

What was wrong with the old visibleContentRect()?
You can use frame->view()->visibleSize() for brevity.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1017
> +        return PassOwnPtr<HighlightConfig> ();

Will "return 0;" work in this case, like it does for PassRefPtr's?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.