[Webkit-unassigned] [Bug 92342] Web Inspector [JSC]: Support multi instance for PageScriptDebugServer of JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92342


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155233|review?                     |review-
               Flag|                            |




--- Comment #22 from Yury Semikhatsky <yurys at chromium.org>  2012-07-30 02:25:00 PST ---
(From update of attachment 155233)
View in context: https://bugs.webkit.org/attachment.cgi?id=155233&action=review

> Source/WebCore/bindings/js/PageScriptDebugServer.h:59
> +    PageScriptDebugServer(Page* = 0);

The constructor should be marked "explicit" also why is the Page parameter 0 by default while it should never be null?

> Source/WebCore/bindings/js/PageScriptDebugServer.h:76
> +    static PageDebugServerMap m_pageDebugServerMap;

m_pageDebugServerMap -> s_pageDebugServerMap as it is a static field.

> Source/WebCore/inspector/InspectorProfilerAgent.cpp:106
> +        return PageScriptDebugServer::server(0);

Worker*Agent must not depend on Page*Server. There should be a separate map WorkerContext -> WorkerScriptDebugServer.

> Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:-105
> -            PageScriptDebugServer::shared().continueProgram();

You don't need to rename this getter for V8 bindings as the patch doesn't affect their functionality.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.