[Webkit-unassigned] [Bug 92342] Web Inspector [JSC]: Support multi instance for PageScriptDebugServer of JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92342





--- Comment #23 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-07-30 02:53:54 PST ---
(In reply to comment #22)
> (From update of attachment 155233 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155233&action=review
> 
> > Source/WebCore/bindings/js/PageScriptDebugServer.h:59
> > +    PageScriptDebugServer(Page* = 0);
> 
> The constructor should be marked "explicit" 
Sure. Thx.
> also why is the Page parameter 0 by default while it should never be null?
Sorry. It comes from old patch. 
> > Source/WebCore/bindings/js/PageScriptDebugServer.h:76
> > +    static PageDebugServerMap m_pageDebugServerMap;
> 
> m_pageDebugServerMap -> s_pageDebugServerMap as it is a static field.
ok.
> > Source/WebCore/inspector/InspectorProfilerAgent.cpp:106
> > +        return PageScriptDebugServer::server(0);
> 
> Worker*Agent must not depend on Page*Server. There should be a separate map WorkerContext -> WorkerScriptDebugServer.
I see, thank you. 
> > Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp:-105
> > -            PageScriptDebugServer::shared().continueProgram();
> 
> You don't need to rename this getter for V8 bindings as the patch doesn't affect their functionality.
Sorry, I didn't understand this comment very well. 
I renamed "JSC::PageScriptDebugServer::shared" to "server", and I had to rename "V8::PageScriptDebugServer::shared" to "server", because if not, high level function like PageDebuggerAgent::scriptDebugServer have to recognize now is V8 or JSC. So I also modified WebDevToolsAgentImpl.cpp to make it pass compiling.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.