[Webkit-unassigned] [Bug 92261] [gtk] Add wk1 method for snapshotting a webview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92261


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #154938|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2012-07-27 08:25:44 PST ---
(From update of attachment 154938)
View in context: https://bugs.webkit.org/attachment.cgi?id=154938&action=review

Looks good to me apart from two minor changes!

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5273
> +webkit_web_view_get_snapshot(WebKitWebView *webView)

The asterisk should be up against the type here.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5284
> +    cairo_surface_t* surface = cairo_image_surface_create(CAIRO_FORMAT_RGB24, allocation.width, allocation.height);

Changing this to CAIRO_FORMAT_ARGB32 and adding a clearRect (see the call in ChromeClient) below would ensure that transparent backgrounds work.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.