[Webkit-unassigned] [Bug 92261] [gtk] Add wk1 method for snapshotting a webview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92261





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-07-27 07:27:21 PST ---
(From update of attachment 154938)
View in context: https://bugs.webkit.org/attachment.cgi?id=154938&action=review

API looks good to me, I just wonder whether it would be useful to pass the clip rect. In any case we need the approval from another reviewer for this.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5264
> + * webkit_web_view_get_snapshot:
> + * @web_view: a #WebKitWebView

I wonder if we could pass a rectangle to the method, or even having two methods and this one could call the one taking a rectangle with the view allocation.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5270
> + * Since: 1.9.5

Use stable version numbers in Since tags, and 1.9.5 was already released :-) Use 1.10 in this case, please.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5275
> +    GtkAllocation allocation;

Move this right before gtk_widget_get_allocation()

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5277
> +    g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), NULL);

Use 0 instead of NULL.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5281
> +        return NULL;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.