[Webkit-unassigned] [Bug 91592] [EFL] Highlight the element under mouse on web inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91592





--- Comment #11 from Seokju Kwon <seokju.kwon at samsung.com>  2012-07-25 19:11:19 PST ---
(In reply to comment #10)
> (From update of attachment 154473 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154473&action=review
> 
> The rest looks good.
> 
> > Source/WebKit/efl/ewk/ewk_paint_context.cpp:181
> > +        WebCore::InspectorController* controller = page->inspectorController();
> 
> I wonder if page always has inspector controller. If not, I think below condition is good to avoid crash.
> 
> if (WebCore::InspectorController* controller = page->inspectorController())
>     if (controller->highlightedNode())
>         controller->drawHighlight(*context->graphicContext);

It seems to me that page always has inspectorController.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.