[Webkit-unassigned] [Bug 91592] [EFL] Highlight the element under mouse on web inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 25 18:10:47 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91592





--- Comment #10 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-25 18:10:50 PST ---
(From update of attachment 154473)
View in context: https://bugs.webkit.org/attachment.cgi?id=154473&action=review

The rest looks good.

> Source/WebKit/efl/ewk/ewk_paint_context.cpp:181
> +        WebCore::InspectorController* controller = page->inspectorController();

I wonder if page always has inspector controller. If not, I think below condition is good to avoid crash.

if (WebCore::InspectorController* controller = page->inspectorController())
    if (controller->highlightedNode())
        controller->drawHighlight(*context->graphicContext);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list