[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implement color chooser interface for EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-25 01:05:20 PST ---
(From update of attachment 154272)
View in context: https://bugs.webkit.org/attachment.cgi?id=154272&action=review

Could you explain how to implement color picker by application based on this new APIs ?

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] Implement color chooser interface for EFL

I think this patch implements input picker as well. So, I think it is better to mention input picker as well.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:73
> +    OwnPtr<InputPicker> inputPicker;

I think below location is proper place for this variable definition.

http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp#L55

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:308
> +    priv->inputPicker = nullptr;

You don't need to delete data based on OwnPtr. OwnPtr calls "delete" on that pointer when it goes out of scope.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:108
> +    Eina_Bool (*input_picker_show)(Ewk_View_Smart_Data *sd, Ewk_Input_Type inputType, const char* inputValue);

I'm sorry I missed this previous review.

s/inputType/input_type/g and s/inputValue/input_value/g

Move '*' to variable side.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.