[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implement color chooser interface for EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #6 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-25 01:02:10 PST ---
(From update of attachment 154272)
View in context: https://bugs.webkit.org/attachment.cgi?id=154272&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:301
> +    priv->inputPicker = adoptPtr<InputPicker>(new InputPicker(smartData->self));

This should be moved to the Ewk_View_Private_Data constructor.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:308
> +    priv->inputPicker = nullptr;

Useless, please remove.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1049
> +    if (priv->colorChooser)

You should return early. if (!priv->colorChooser) return;

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:108
> +    Eina_Bool (*input_picker_show)(Ewk_View_Smart_Data *sd, Ewk_Input_Type inputType, const char* inputValue);

star on wrong side.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:469
> + *

We should document the format of the color argument? Hexadecimal only?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:473
> +EAPI void ewk_view_color_chooser_color_set(Evas_Object *o, const char *color);

You can set but not get the color?
Also, we usually return Eina_Bool for setters.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:480
> +EAPI void ewk_view_color_chooser_close(Evas_Object *o);

We usually return Eina_Bool.

> Source/WebKit2/UIProcess/efl/WebColorChooserProxyEfl.h:46
> +    ~WebColorChooserProxyEfl();

You have virtual methods, the destructor needs to be virtual.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.