[Webkit-unassigned] [Bug 91274] Add FastMalloc statistics in window.internals

Mon Jul 23 08:12:00 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=91274

--- Comment #24 from Olivier Blin <olivier.blin at softathome.com>  2012-07-23 08:12:01 PST ---
(In reply to comment #23)
> (From update of attachment 153475 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153475&action=review
> 
> > Source/WebCore/testing/FastMallocStatistics.h:46
> > +        m_stats = WTF::fastMallocStatistics();
> 
> If we're storing the statistics at the object creation, then we probably need to make the creation explicit instead of making it hang off of internals.
>
> > Source/WebCore/testing/Internals.idl:179
> > +        readonly attribute FastMallocStatistics fastMallocStatistics;
> 
> i.e. this should be a function call instead of being an object in order to allow getting statistics multiple times without being dependent on GC behavior.

Thanks, I will change it to a function call.

I followed the model used for console.memory, which uses a readonly attribute as well.
Does it mean that getting fresh stats in console.memory would depend on the GC?

> > LayoutTests/fast/harness/fastmallocstatistics-object.html:1
> > +<html>
> 
> Missing DOCTYPE.

Ok, I will add one (some tests in the harness dir are missing it as well).

Thanks for the review

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.