[Webkit-unassigned] [Bug 91274] Add FastMalloc statistics in window.internals

Fri Jul 20 11:09:14 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=91274

--- Comment #23 from Ryosuke Niwa <rniwa at webkit.org>  2012-07-20 11:09:14 PST ---
(From update of attachment 153475)
View in context: https://bugs.webkit.org/attachment.cgi?id=153475&action=review

> Source/WebCore/testing/FastMallocStatistics.h:46
> +        m_stats = WTF::fastMallocStatistics();

If we're storing the statistics at the object creation, then we probably need to make the creation explicit instead of making it hang off of internals.

> Source/WebCore/testing/Internals.idl:179
> +        readonly attribute FastMallocStatistics fastMallocStatistics;

i.e. this should be a function call instead of being an object in order to allow getting statistics multiple times without being dependent on GC behavior.

> LayoutTests/fast/harness/fastmallocstatistics-object.html:1
> +<html>

Missing DOCTYPE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.