[Webkit-unassigned] [Bug 91877] [Chromium] Broken image icon does not appear in high dpi

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91877





--- Comment #4 from Dana Jansens <danakj at chromium.org>  2012-07-20 12:42:25 PST ---
(From update of attachment 153530)
View in context: https://bugs.webkit.org/attachment.cgi?id=153530&action=review

>>> Source/WebCore/rendering/RenderImage.cpp:317
>>> +            if (m_imageResource->errorOccurred() && deviceScaleFactor*usableWidth >= image->width() && deviceScaleFactor*usableHeight >= image->height() && !image->isNull()) {
>> 
>> why not just change the value of usable* when they are being set above? Should the "- 2" be scaled by deviceScaleFactor also?
> 
> The value is used below and need to be in original form, otherwise the image will be in a wrong position.
> 
> If usableWidth represents what it's supposed to (usable width), then I'd guess all its components should be scaled.
> 
> Also see comments on crbug.com/136118.

Ok, the image is scaled by only deviceScaleFactor, so I agree this seems right to do if the context scale is always >= deviceScaleFactor. This does seem right in the context scale = deviceScale case, and won't be any different in other cases.

style nit: put spaces around * and maybe consider using a temporary variable for them eg deviceScaledUsuableWidth.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.