[Webkit-unassigned] [Bug 91877] [Chromium] Broken image icon does not appear in high dpi

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 20 12:30:37 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91877





--- Comment #3 from zlieber at chromium.org  2012-07-20 12:30:40 PST ---
(In reply to comment #2)
> (From update of attachment 153530 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153530&action=review
> 
> > Source/WebCore/rendering/RenderImage.cpp:317
> > +            if (m_imageResource->errorOccurred() && deviceScaleFactor*usableWidth >= image->width() && deviceScaleFactor*usableHeight >= image->height() && !image->isNull()) {
> 
> why not just change the value of usable* when they are being set above? Should the "- 2" be scaled by deviceScaleFactor also?

The value is used below and need to be in original form, otherwise the image will be in a wrong position.

If usableWidth represents what it's supposed to (usable width), then I'd guess all its components should be scaled.

Also see comments on crbug.com/136118.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list