[Webkit-unassigned] [Bug 91506] Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91506





--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2012-07-19 12:55:01 PST ---
(In reply to comment #4)

> I am still working on getting the patch.  It will be a really trivial patch, I'm just trying to follow the process...

Thanks for taking the time to do this!


> This brings up a good question though.  Do you think it's possible/reasonable to create a test for this fix?

I think it would be possible, but I'm not sure how reasonable it is. This was just an unfortunate typo, and the fix is straight forward. This is akin to a build fix.

Another interesting aspect of this is that we might be "leaking" these fonts, because the default value for getCachedFontData is to retain the font. So they are probably getting abandoned in the FontCache forever. For these kind of performance issues / improvements we normally don't require tests if they were shown to fix an issue.

And maybe this is already covered by some tests and we just have incorrect expected results for windows? You could attach a simple patch + changelog, and we can run that patch on the "Early Warning System" bots and see if it affects any tests. There is a Windows EWS bot.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.