[Webkit-unassigned] [Bug 91506] Typo in FontCacheWin.cpp causes return value from getCachedFontData() in getLastResortFallbackFont() to be ignored

Thu Jul 19 12:28:25 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=91506

--- Comment #4 from Mark Salisbury <mark.salisbury at hp.com>  2012-07-19 12:28:25 PST ---
Thanks Joe for following up to see where I am.

I got run-webkit-tests running against a wincairo build, then saw some fails that were unexpected so I built the standard apple "release" build yesterday... It's running now but TONS of tests are failing.  I expect it has nothing to do with my code change and more something being wrong in my environment.

I am still working on getting the patch.  It will be a really trivial patch, I'm just trying to follow the process...

This brings up a good question though.  Do you think it's possible/reasonable to create a test for this fix?

I'm not sure how we could create a test for this.  The "fallback fallback" code ends up creating a font, so you always get a fallback font even with this code bug.  The default font (WebCore::Settings) needs to be changed to one that's not available on the system during the testing (and I think that is possible using the internals testing object).  However, the exact font that we would then fallback to depends on user preferences (system control panel settings).  This is a very platform specific issue.  It would be easier to create a test that would show this on WinCE, since it doesn't have the final fallback code, but we don't have layout tests for WinCE at this point in time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.