[Webkit-unassigned] [Bug 89223] [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89223





--- Comment #5 from Mario Sanchez Prada <msanchez at igalia.com>  2012-07-18 03:13:05 PST ---
Thanks Chris for reviewing this, just got back from holidays today, so please understand my late reply.

(In reply to comment #4)
> (From update of attachment 148083 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=148083&action=review
> 
> looks good. a few minor nits
> 
> > Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:181
> > +{
> 
> seems like you could probably implement this method pretty easily

Indeed. I just haven't done it so since I was more worried at this point about porting DRT stuff to WKTR rather than adding new stuff.

Still, I agree implementation for this one is very simple, so I just added it.

> > Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:256
> > +    AtkObject* parent =  atk_object_get_parent(ATK_OBJECT(m_element));
> 
> extra white space after = sign

For some reason check-webkit-style didn't get this one. Thanks for pointing it out.

> > Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:863
> > +    // FIXME: implement
> 
> two FIXME's here
> 
> > Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:869
> > +    // FIXME: implement
> 
> two FIXMEs here

Both fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.