[Webkit-unassigned] [Bug 89223] [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89223


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #148083|review?                     |review+
               Flag|                            |




--- Comment #4 from chris fleizach <cfleizach at apple.com>  2012-07-06 09:48:45 PST ---
(From update of attachment 148083)
View in context: https://bugs.webkit.org/attachment.cgi?id=148083&action=review

looks good. a few minor nits

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:181
> +{

seems like you could probably implement this method pretty easily

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:256
> +    AtkObject* parent =  atk_object_get_parent(ATK_OBJECT(m_element));

extra white space after = sign

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:863
> +    // FIXME: implement

two FIXME's here

> Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:869
> +    // FIXME: implement

two FIXMEs here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.