[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91351





--- Comment #26 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-17 02:02:12 PST ---
(From update of attachment 152713)
View in context: https://bugs.webkit.org/attachment.cgi?id=152713&action=review

>>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:977
>>> +    } else {
>> 
>> Should we distinguish this ? I think we just set userAgent to WKPageSetCustomUserAgent. If user wanna set NULL as user agent, it just set NULL to parameter. So, we don't need to split this condition.
>> 
>> In addition, I don't see other ports has similar logic yet.
> 
> If userAgent parameter is null, the default user agent may be set by WKPageSetCustomUserAgent.
> Then, priv->userAgent is also set to the default user agent.
> That's because the const char * is managed separately in ewk_view like title, uri.

Do you think we should not support null as user agent value? I think this is our policy. We can decide whether we return default user agent when user agent parameter is NULL. But, though user wanna set user agent with NULL value, I don't know why we should return default user agent. It seems to me other ports allow to set NULL to user agent. Is there any reason to return default user agent when user agent parameter is NULL ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.