[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 17 01:42:50 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=91351
--- Comment #25 from Hyerim Bae <hyerim.bae at samsung.com> 2012-07-17 01:42:49 PST ---
(From update of attachment 152713)
View in context: https://bugs.webkit.org/attachment.cgi?id=152713&action=review
>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:977
>> + } else {
>
> Should we distinguish this ? I think we just set userAgent to WKPageSetCustomUserAgent. If user wanna set NULL as user agent, it just set NULL to parameter. So, we don't need to split this condition.
>
> In addition, I don't see other ports has similar logic yet.
If userAgent parameter is null, the default user agent may be set by WKPageSetCustomUserAgent.
Then, priv->userAgent is also set to the default user agent.
That's because the const char * is managed separately in ewk_view like title, uri.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list