[Webkit-unassigned] [Bug 89864] [EFL][WK2] Add ewk_view_ui_client

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 15 21:58:53 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=89864





--- Comment #23 from Christophe Dumez <christophe.dumez at intel.com>  2012-07-15 21:58:52 PST ---
(From update of attachment 151661)
View in context: https://bugs.webkit.org/attachment.cgi?id=151661&action=review

>>> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:33
>>> +    Evas_Object* ewkView = static_cast<Evas_Object*>(const_cast<void*>(clientInfo));
>> 
>> How about defining a "static inline Evas_Object* toEwkView(const void* clientInfo);" function for the casting and use it in all callbacks?
> 
> It seems that is may be handled with other clients. How about making another patch for it?

I would prefer if it was refactored in this patch. It is cleaner and more extensible. This is just 4 additional lines and it saves 2 lines. It would also serve as a good practice example.

> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:34
> +    ewk_view_page_close(ewkView);

ewk_view_page_close(toEwkView(clientInfo));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list