[Webkit-unassigned] [Bug 89864] [EFL][WK2] Add ewk_view_ui_client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89864





--- Comment #22 from Hyerim Bae <hyerim.bae at samsung.com>  2012-07-15 17:47:42 PST ---
(From update of attachment 151661)
View in context: https://bugs.webkit.org/attachment.cgi?id=151661&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:818
>> +    evas_object_smart_callback_call(ewkView, "close,window", 0);
> 
> No EINA_SAFETY check?

Other client callback also doesn't check it.
And It seems that it is unnecessary because the ewkView is already checked null when it is created in ewk_view_base_add,
then it is used as a parameter of all other clients.

>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:823
>> +    Evas_Object* newEwkView = 0;
> 
> Ditto.

Ditto.

>> Source/WebKit2/UIProcess/API/efl/ewk_view_ui_client.cpp:33
>> +    Evas_Object* ewkView = static_cast<Evas_Object*>(const_cast<void*>(clientInfo));
> 
> How about defining a "static inline Evas_Object* toEwkView(const void* clientInfo);" function for the casting and use it in all callbacks?

It seems that is may be handled with other clients. How about making another patch for it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.