[Webkit-unassigned] [Bug 91196] Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91196





--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2012-07-13 12:43:58 PST ---
> We need to also introduce method like frontendChannel() in InspectorClient so as to refer this from InspectorController:
> 
> class InspectorClient {
> public:
>     virtual InspectorFrontendChannel* frontendChannel() const = 0;
> }
> 
> The method would typically return "this" from the implementation(e.g. InspectorClientQt)

That would be wrong. The point of this refactoring is to separate the channel from the client. Your testing harness will be setting the generic channel, but the clients will be port-specific.

connectFrontend will receive frontend channel instance as a parameter and will store a raw pointer to it in the InspectorController. disconnectFrontend will clear that internal pointer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.